This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Improve mochi errors#3647
Merged
Merged
Conversation
315c689 to
1a95251
Compare
Codecov Report
@@ Coverage Diff @@
## master #3647 +/- ##
==========================================
+ Coverage 54.49% 54.84% +0.34%
==========================================
Files 120 120
Lines 4786 4812 +26
Branches 992 1001 +9
==========================================
+ Hits 2608 2639 +31
+ Misses 2178 2173 -5
Continue to review full report at Codecov.
|
bomsy
reviewed
Aug 14, 2017
| } | ||
|
|
||
| function onGecko(line) { | ||
| function onFrame(line, data) { |
Contributor
There was a problem hiding this comment.
nit: looks like data is not needed
Contributor
Author
There was a problem hiding this comment.
true... I'll move this file to a place where prettier works and then we'll find other terrible things.
bomsy
approved these changes
Aug 14, 2017
1a95251 to
2eca854
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3623
Summary of Changes
modestate to a data object so that tests can run in parallelBefore
After