Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Rename spec files#3642

Merged
jasonLaster merged 6 commits into
firefox-devtools:masterfrom
Ronsho:rename-spec-files
Aug 14, 2017
Merged

Rename spec files#3642
jasonLaster merged 6 commits into
firefox-devtools:masterfrom
Ronsho:rename-spec-files

Conversation

@Ronsho
Copy link
Copy Markdown
Contributor

@Ronsho Ronsho commented Aug 12, 2017

Associated Issue: #3243

Here's the Pull Request Doc
https://devtools-html.github.io/debugger.html/CONTRIBUTING.html#pull-requests

Summary of Changes

  1. Added the spec suffix to all unit tests
  2. Added the spec suffix to all integration tests
  3. Updated snapshots tests

@Ronsho Ronsho changed the title Rename spec files Rename spec files [WIP] Aug 12, 2017
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 12, 2017

Codecov Report

Merging #3642 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3642   +/-   ##
=======================================
  Coverage   54.51%   54.51%           
=======================================
  Files         120      120           
  Lines        4786     4786           
  Branches      992      992           
=======================================
  Hits         2609     2609           
  Misses       2177     2177

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a3af46...10c112d. Read the comment docs.

@Ronsho Ronsho changed the title Rename spec files [WIP] Rename spec files Aug 12, 2017
@jasonLaster
Copy link
Copy Markdown
Contributor

Thanks! I think at the moment, I prefer just updating the jest unit tests.

The stories might get their own suffix and mochitests already have the annoying browser_dbg prefix :)

@Ronsho
Copy link
Copy Markdown
Contributor Author

Ronsho commented Aug 12, 2017

@jasonLaster , done

@jasonLaster jasonLaster merged commit 7b4fa60 into firefox-devtools:master Aug 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants