This repository was archived by the owner on Jan 11, 2023. It is now read-only.
test project search#3639
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3639 +/- ##
==========================================
+ Coverage 54.68% 54.83% +0.14%
==========================================
Files 120 120
Lines 4820 4811 -9
Branches 1002 1001 -1
==========================================
+ Hits 2636 2638 +2
+ Misses 2184 2173 -11
Continue to review full report at Codecov.
|
codehag
reviewed
Aug 14, 2017
| .map(file => file.matches) | ||
| .toJS(); | ||
|
|
||
| return [].concat(...matches).length; |
Contributor
There was a problem hiding this comment.
could we do [...matches].length? or matches.length?
Contributor
There was a problem hiding this comment.
also, since we are doing toJS() at the end here, maybe it makes more sense to do matches.size
codehag
approved these changes
Aug 14, 2017
Contributor
codehag
left a comment
There was a problem hiding this comment.
looks good, a couple of comments regarding the immutable -> js stuff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
I'm adding a mochitest so that we can have a simple smoke test. Also, importantly i'm using prefs instead of configs to flag project search because we need to be able to flip it in the test.