This repository was archived by the owner on Jan 11, 2023. It is now read-only.
convert ProjectSearch/*.js files to JSX#3636
Merged
jasonLaster merged 1 commit intoAug 11, 2017
Merged
Conversation
jasonLaster
reviewed
Aug 11, 2017
| {getRelativePath(file.filepath)} | ||
| </span> | ||
| <span className="matches-summary"> | ||
| {` (${file.matches.length} match${file.matches.length > 1 |
Contributor
There was a problem hiding this comment.
lets move this up to a variable. I'm still not comfortable with JSXy expressions
| onClick={e => setExpanded(file, !expanded)} | ||
| > | ||
| <Arrow | ||
| className={classnames({ |
| return ( | ||
| <ManagedTree | ||
| getRoots={() => results} | ||
| getChildren={file => { |
Contributor
There was a problem hiding this comment.
can this be file => file.matches || []
| focused={results[0]} | ||
| getParent={item => null} | ||
| getPath={getFilePath} | ||
| renderItem={(item, depth, focused, _, expanded, { setExpanded }) => |
Contributor
There was a problem hiding this comment.
lets move this out... renderItem={renderItem}
Codecov Report
@@ Coverage Diff @@
## master #3636 +/- ##
==========================================
- Coverage 54.51% 54.49% -0.03%
==========================================
Files 120 120
Lines 4786 4786
Branches 992 992
==========================================
- Hits 2609 2608 -1
- Misses 2177 2178 +1
Continue to review full report at Codecov.
|
3519a73 to
db6b20f
Compare
jasonLaster
approved these changes
Aug 11, 2017
aklt
added a commit
to aklt/debugger.html
that referenced
this pull request
Aug 12, 2017
* fixes issues introduced by firefox-devtools#3636
aklt
added a commit
to aklt/debugger.html
that referenced
this pull request
Aug 12, 2017
* fixes issues introduced by firefox-devtools#3636
jasonLaster
pushed a commit
that referenced
this pull request
Aug 12, 2017
* fixes issues introduced by #3636
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3506
Converted the files
To JSX.
The behaviour should be as before. See
For an example gif showing the expected behaviour.