Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

SVG - only throw in development#3628

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:fix-angular
Aug 11, 2017
Merged

SVG - only throw in development#3628
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:fix-angular

Conversation

@jasonLaster
Copy link
Copy Markdown
Contributor

@jasonLaster jasonLaster commented Aug 10, 2017

Associated Issue: #3596

Summary of Changes

We have an embarrassing bug where angular is missing an svg so it throws an error in the panel. This fixes that

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 10, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@cad5c80). Click here to learn what that means.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3628   +/-   ##
=========================================
  Coverage          ?   54.44%           
=========================================
  Files             ?      120           
  Lines             ?     4755           
  Branches          ?      982           
=========================================
  Hits              ?     2589           
  Misses            ?     2166           
  Partials          ?        0
Impacted Files Coverage Δ
assets/images/Svg.js 66.66% <16.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad5c80...1d9e195. Read the comment docs.

@jasonLaster jasonLaster merged commit 1b4523d into firefox-devtools:master Aug 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants