Update assertPausedLocation#3622
Conversation
| * @static | ||
| */ | ||
| function assertPausedLocation(dbg, source, line) { | ||
| function assertPausedLocation(dbg) { |
There was a problem hiding this comment.
we're dropping specified source and lines because we want to focus on the fact that we're highlighting the top frame line.
a486a1a to
ceb5ce1
Compare
Codecov Report
@@ Coverage Diff @@
## master #3622 +/- ##
==========================================
- Coverage 54.48% 54.46% -0.03%
==========================================
Files 120 120
Lines 4750 4750
Branches 981 981
==========================================
- Hits 2588 2587 -1
- Misses 2162 2163 +1
Continue to review full report at Codecov.
|
3c6a049 to
ceb5ce1
Compare
ceb5ce1 to
850062e
Compare
codehag
left a comment
There was a problem hiding this comment.
Looks good, should assertPausedLocation be renamed to something like assertPausedFrame? give a bit more context for what is going on?
|
I still think location makes sense, because it's the location of the frame we care about, but I see where you're going with that. Lets revisit if we want to add our own location expectation. |
Summary of Changes
Update assertPausedLocation, this lets us run
./mach mochitest --repat 20 browser_browser_toolbox_debugger.jssuccessfully. previously it would fail hard.We're updating
assertPausedLocationbecause the browser toolbox occasionally steps into a weird sourceGCTelemettry