Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Convert SearchBar to JSX#3617

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
wldcordeiro:jsx-searchbar
Aug 10, 2017
Merged

Convert SearchBar to JSX#3617
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
wldcordeiro:jsx-searchbar

Conversation

@wldcordeiro
Copy link
Copy Markdown
Contributor

Associated Issue: #3506

Summary of Changes

  • convert SearchBar to JSX

Test Plan

  • Command-F opens the searchbar
  • Typing text searches
  • Toggling modifiers modifies search
  • escape closes the searchbar

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 10, 2017

Codecov Report

Merging #3617 into master will decrease coverage by 0.06%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3617      +/-   ##
==========================================
- Coverage   54.54%   54.48%   -0.07%     
==========================================
  Files         120      120              
  Lines        4750     4750              
  Branches      981      981              
==========================================
- Hits         2591     2588       -3     
- Misses       2159     2162       +3
Impacted Files Coverage Δ
src/components/Editor/SearchBar.js 31.6% <20%> (-2.3%) ⬇️
src/actions/ast.js 78.57% <0%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b380c...ce7ff50. Read the comment docs.

@jasonLaster jasonLaster merged commit 6b78768 into firefox-devtools:master Aug 10, 2017
@wldcordeiro wldcordeiro deleted the jsx-searchbar branch August 10, 2017 15:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants