Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Fix positioning of source search no results message#3616

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
wldcordeiro:fix-no-results
Aug 10, 2017
Merged

Fix positioning of source search no results message#3616
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
wldcordeiro:fix-no-results

Conversation

@wldcordeiro
Copy link
Copy Markdown
Contributor

@wldcordeiro wldcordeiro commented Aug 10, 2017

Associated Issue: #3547

Summary of Changes

  • set autocomplete height to 100% so the message centers properly.

Screenshots/Videos

screen shot 2017-08-09 at 9 11 56 pm

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 10, 2017

Codecov Report

Merging #3616 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3616   +/-   ##
=======================================
  Coverage   54.54%   54.54%           
=======================================
  Files         120      120           
  Lines        4750     4750           
  Branches      981      981           
=======================================
  Hits         2591     2591           
  Misses       2159     2159

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b380c...e6f9db3. Read the comment docs.

Copy link
Copy Markdown
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

why did it break?

@jasonLaster jasonLaster merged commit b8407a3 into firefox-devtools:master Aug 10, 2017
@wldcordeiro wldcordeiro deleted the fix-no-results branch August 10, 2017 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants