This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Add mochi runner#3609
Merged
Merged
Conversation
gregtatum
reviewed
Aug 9, 2017
| @@ -0,0 +1,210 @@ | |||
| const shell = require("shelljs"); | |||
Member
There was a problem hiding this comment.
Do you not flow type your bin scripts? I really like treating all my code as first class citizens.
gregtatum
approved these changes
Aug 9, 2017
Member
gregtatum
left a comment
There was a problem hiding this comment.
It all looks reasonable to me, did you test this on Windows? Seems like something worth doing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The goal is to be able to make it fun to run integration tests. We do this by cleaning up the workflow a lot:
yarn mochi