Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Added option to remove all breakpoints#3608

Merged
jasonLaster merged 3 commits into
firefox-devtools:masterfrom
sagorika1996:remove-all-breakpoints
Aug 10, 2017
Merged

Added option to remove all breakpoints#3608
jasonLaster merged 3 commits into
firefox-devtools:masterfrom
sagorika1996:remove-all-breakpoints

Conversation

@sagorika1996
Copy link
Copy Markdown
Contributor

Associated Issue: #3575

Summary of Changes

  • Added option to remove currently selected breakpoint
  • Added option to remove all breakpoints

ezgif com-video-to-gif 2

Comment thread assets/panel/debugger.properties Outdated

# LOCALIZATION NOTE (breakpointMenuItem.deleteSelf): Access key to remove the
# currently selected breakpoint from the context menu
breakpointMenuItem.deleteAll.accesskey=r
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be deleteSelf

Comment thread assets/panel/debugger.properties Outdated
breakpointMenuItem.disableAll=Disable all breakpoints
breakpointMenuItem.deleteAll=Remove all breakpoints

# LOCALIZATION NOTE (breakpointMenuItem.deleteSelf): Access key to remove the
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breakpointMenuItem.deleteSelf.accesskey

@jasonLaster
Copy link
Copy Markdown
Contributor

@sagorika1996 small l10n things, but otherwise looks great

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 10, 2017

Codecov Report

Merging #3608 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3608      +/-   ##
==========================================
- Coverage   54.47%   54.41%   -0.06%     
==========================================
  Files         119      119              
  Lines        4663     4666       +3     
  Branches      963      963              
==========================================
- Hits         2540     2539       -1     
- Misses       2123     2127       +4
Impacted Files Coverage Δ
src/actions/breakpoints.js 80% <0%> (-4.71%) ⬇️
src/components/SecondaryPanes/Frames/WhyPaused.js 90.47% <0%> (-0.83%) ⬇️
src/actions/ast.js 78.57% <0%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d4c714...50f3554. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 10, 2017

Codecov Report

Merging #3608 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3608      +/-   ##
==========================================
- Coverage   54.47%   54.39%   -0.08%     
==========================================
  Files         119      119              
  Lines        4663     4666       +3     
  Branches      963      963              
==========================================
- Hits         2540     2538       -2     
- Misses       2123     2128       +5
Impacted Files Coverage Δ
src/actions/breakpoints.js 80% <0%> (-4.71%) ⬇️
src/components/SecondaryPanes/Frames/WhyPaused.js 90.47% <0%> (-0.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d4c714...d875eaa. Read the comment docs.

);

const removeBreakpointKey = L10N.getStr(
"breakpointMenuItem.deleteAll.accesskey"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be deleteSelf?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jasonLaster jasonLaster merged commit caa3b98 into firefox-devtools:master Aug 10, 2017
@jasonLaster
Copy link
Copy Markdown
Contributor

Thanks so much!

@sagorika1996 sagorika1996 deleted the remove-all-breakpoints branch August 11, 2017 10:42
@sagorika1996 sagorika1996 restored the remove-all-breakpoints branch August 11, 2017 11:16
@sagorika1996 sagorika1996 deleted the remove-all-breakpoints branch August 19, 2017 05:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants