This repository was archived by the owner on Jan 11, 2023. It is now read-only.
click "functions" to open symbol search modal#3607
Merged
jasonLaster merged 2 commits intoAug 10, 2017
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3607 +/- ##
==========================================
+ Coverage 54.54% 54.58% +0.04%
==========================================
Files 120 120
Lines 4778 4776 -2
Branches 991 991
==========================================
+ Hits 2606 2607 +1
+ Misses 2172 2169 -3
Continue to review full report at Codecov.
|
jasonLaster
reviewed
Aug 10, 2017
| this.props.setActiveSearch("symbol"); | ||
| } | ||
| }, | ||
| "functions" |
Contributor
There was a problem hiding this comment.
Lets change this to Search for functions and move it to L10N
https://github.com/devtools-html/debugger.html/blob/master/docs/local-development.md#l10n
739e987 to
6ad527d
Compare
Contributor
|
Modifiers and the buttons too (maybe) look a bit big |
jasonLaster
reviewed
Aug 10, 2017
| <div className="search-type-toggles"> | ||
| <span | ||
| className="search-type-name" | ||
| onClick={() => { |
Contributor
There was a problem hiding this comment.
onClick={() => this.props.setActiveSearch("symbol")}
because, why not
Contributor
Author
There was a problem hiding this comment.
Do you mean the formatting?
6ad527d to
55e0074
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3233
Summary of Changes
Test Plan
Screenshots/Videos (OPTIONAL)