This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Use theme body color for conditional breaking point#3586
Merged
jasonLaster merged 1 commit intoAug 7, 2017
Conversation
Contributor
|
Nice! can you share some before and after screenshots. Also, curious, but it might be nice to see if you can drop CodeMirror into the panel :) |
Codecov Report
@@ Coverage Diff @@
## master #3586 +/- ##
==========================================
- Coverage 54.35% 52.98% -1.38%
==========================================
Files 119 119
Lines 4660 4660
Branches 962 962
==========================================
- Hits 2533 2469 -64
- Misses 2127 2191 +64
Continue to review full report at Codecov.
|
Contributor
Author
|
I'm not sure why the build indicates a drop in the test coverage. |
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3577
#goodnessSquad
Here's the Pull Request Doc
https://devtools-html.github.io/debugger.html/CONTRIBUTING.html#pull-requests
Summary of Changes
Test Plan
Tested the color of the conditional breaking point input color is updated correctly.
Before:
After:
