This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Show result list#3585
Merged
Merged
Conversation
jasonLaster
commented
Aug 7, 2017
| } | ||
| </div> | ||
| </Modal> | ||
| </SymbolModal>" |
Contributor
Author
There was a problem hiding this comment.
this output is pretty nice in snapshots
wldcordeiro
approved these changes
Aug 7, 2017
ee2d043 to
d902821
Compare
Codecov Report
@@ Coverage Diff @@
## master #3585 +/- ##
==========================================
+ Coverage 52.98% 54.35% +1.37%
==========================================
Files 119 119
Lines 4660 4660
Branches 962 962
==========================================
+ Hits 2469 2533 +64
+ Misses 2191 2127 -64
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3584
Summary of Changes
the input wrapper was surrounding results as well. looks like we can easily mess up the dom heirarchy.