Convert Autocomplete, ResultList, and SearchInput to JSX#3582
Conversation
01b2c3b to
3fa111f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3582 +/- ##
==========================================
- Coverage 52.57% 52.56% -0.01%
==========================================
Files 119 119
Lines 4649 4651 +2
Branches 958 957 -1
==========================================
+ Hits 2444 2445 +1
- Misses 2205 2206 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3582 +/- ##
==========================================
+ Coverage 54.53% 54.56% +0.02%
==========================================
Files 120 120
Lines 4747 4750 +3
Branches 982 981 -1
==========================================
+ Hits 2589 2592 +3
Misses 2158 2158
Continue to review full report at Codecov.
|
jasonLaster
left a comment
There was a problem hiding this comment.
One question. Looks great.
| }; | ||
|
|
||
| return ( | ||
| <div className="search-field {size || ''}"> |
There was a problem hiding this comment.
shouldn't it be this: {"search-field ${size || ''}"}
I'm still new at this game
There was a problem hiding this comment.
<div className={classnames("search-field", { size })}> would be even cleaner.
3fa111f to
7dfdcb1
Compare
|
Good shout; updated! |
f8a80fa to
4ffbf49
Compare
|
This PR keeps choking on an old snapshot; how can I generate a new one for the updated components? |
|
@darkwing |
|
@zaggy that option is also available as |
34565b7 to
fb4f825
Compare
|
Tests passing with snapshot update, should be good to go |
wldcordeiro
left a comment
There was a problem hiding this comment.
Awesome @darkwing! Thanks for all the help with the JSX conversions.
#3506