This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Dropdown to JSX#3580
Merged
wldcordeiro merged 1 commit intoAug 6, 2017
Merged
Conversation
jasonLaster
approved these changes
Aug 5, 2017
Contributor
jasonLaster
left a comment
There was a problem hiding this comment.
👍
haven’t tested the tabs dropdown yet though
Contributor
|
don't worry about the test failure. It's a known intermittent we introduced yesterday. |
wldcordeiro
approved these changes
Aug 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3506
Summary of Changes
Test Plan
Desk testing functionality and staring at the code really hard to make sure nothing seems too weird.