#3506 WhyPaused to JSX#3579
Conversation
|
@ksaldana1 any reason why this was closed? That component hasn't been converted to JSX yet. |
Codecov Report
@@ Coverage Diff @@
## master #3579 +/- ##
==========================================
- Coverage 52.59% 52.57% -0.03%
==========================================
Files 119 119
Lines 4649 4649
Branches 958 958
==========================================
- Hits 2445 2444 -1
- Misses 2204 2205 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3579 +/- ##
==========================================
- Coverage 52.59% 52.57% -0.03%
==========================================
Files 119 119
Lines 4649 4649
Branches 958 958
==========================================
- Hits 2445 2444 -1
- Misses 2204 2205 +1
Continue to review full report at Codecov.
|
|
opening (just incase) |
|
The tests failed two linting rules that did not get caught in my editor first time around. I closed the PR until I could get back around to fixing them. Will update this PR in a bit to fix the lint rules below. 22:1 error Component definition is missing display name react/display-name
48:16 error Component definition is missing display name react/display-nameI'm actually a little confused by the error tbh. It's trivially fixed with That felt a little naive, but that's mostly because I didn't fully grok the necessity of the displayName when reading the ESLint rule. If that's an acceptable solution, I'll go ahead and push it up. |
|
Feel free to leave the pr open :)
It's all good
…On Mon, Aug 7, 2017 at 8:44 PM Kevin Saldaña ***@***.***> wrote:
The tests failed two linting rules that did not get caught in my editor
first time around. I closed the PR until I could get back around to fixing
them. Will update to get rid of the errors.
22:1 error Component definition is missing display name react/display-name
48:16 error Component definition is missing display name react/display-name
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3579 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPiYj0qrS8x35LvDLh69H753g8LKRJ1ks5sV6-HgaJpZM4OuVDd>
.
|
|
yeah - that's a good solution. I think its the only one too sorry, i missed your comment earlier |
Associated Issue: #3506
Summary of Changes
Test Plan
Previous snapshot test passes.