This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Update CloseButton to use jsx#3567
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3567 +/- ##
==========================================
- Coverage 52.55% 52.53% -0.02%
==========================================
Files 119 119
Lines 4645 4646 +1
Branches 958 958
==========================================
Hits 2441 2441
- Misses 2204 2205 +1
Continue to review full report at Codecov.
|
wldcordeiro
reviewed
Aug 4, 2017
| onClick={handleClick} | ||
| title={tooltip} | ||
| > | ||
| {Svg("close")} |
Contributor
There was a problem hiding this comment.
Unrelated but it'd be nice to update Svg to take a name prop and then we could have these calls be JSX too.
wldcordeiro
approved these changes
Aug 4, 2017
jasonLaster
approved these changes
Aug 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had a few more minutes, did one more