This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Convert Editor component to JSX.#3554
Merged
Merged
Conversation
jasonLaster
reviewed
Aug 4, 2017
| import Preview from "./Preview"; | ||
| import Breakpoints from "./Breakpoints"; | ||
| import HitMarker from "./HitMarker"; | ||
| import CallSites from "./CallSites"; |
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`ast getOutOfScopeLocations with selected line 1`] = ` | ||
| Object { |
Contributor
There was a problem hiding this comment.
hmm - not sure if we need this! it's a flaky test.
Take it out and we should be able to land it
Codecov Report
@@ Coverage Diff @@
## master #3554 +/- ##
==========================================
- Coverage 52.62% 52.54% -0.09%
==========================================
Files 119 119
Lines 4650 4644 -6
Branches 957 957
==========================================
- Hits 2447 2440 -7
- Misses 2203 2204 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3506
Summary of Changes
Test Plan
Tell us a little a bit about how you tested your patch.
Example test plan: