This repository was archived by the owner on Jan 11, 2023. It is now read-only.
[PrettyPrint] add unit tests for toggle pretty print#3545
Merged
jasonLaster merged 1 commit intoAug 3, 2017
Conversation
jasonLaster
approved these changes
Aug 3, 2017
| await dispatch(actions.togglePrettyPrint(source.id)); | ||
| expect(getSources(getState()).size).toEqual(2); | ||
| await dispatch(actions.togglePrettyPrint(source.id)); | ||
| expect(getSources(getState()).size).toEqual(2); |
Contributor
There was a problem hiding this comment.
lets have a more specific assertion like the new source URL or a snapshot
Contributor
There was a problem hiding this comment.
I see, we don't really have a good API for getting the mapped sources... nevermind
| ); | ||
|
|
||
| dispatch(remapBreakpoints(sourceId)); | ||
| await dispatch(remapBreakpoints(sourceId)); |
Codecov Report
@@ Coverage Diff @@
## master #3545 +/- ##
==========================================
+ Coverage 51.86% 53.07% +1.21%
==========================================
Files 119 112 -7
Lines 4647 4563 -84
Branches 954 942 -12
==========================================
+ Hits 2410 2422 +12
+ Misses 2237 2141 -96Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3531
Added tests