This repository was archived by the owner on Jan 11, 2023. It is now read-only.
[Expressions] should have a unique key#3543
Merged
jasonLaster merged 2 commits intoAug 3, 2017
Merged
Conversation
- change getKey to getPath to maybe make it clearer that it has more tasks than setting the key - make objectInspector getPath method create a unique path, even if the element is undefined
jasonLaster
reviewed
Aug 3, 2017
|
|
||
| const isEmpty = sourceTree.contents.length === 0; | ||
|
|
||
| console.log(listItems); |
Codecov Report
@@ Coverage Diff @@
## master #3543 +/- ##
==========================================
- Coverage 52.26% 51.94% -0.32%
==========================================
Files 118 113 -5
Lines 4556 4653 +97
Branches 937 957 +20
==========================================
+ Hits 2381 2417 +36
- Misses 2175 2236 +61Continue to review full report at Codecov.
|
jasonLaster
approved these changes
Aug 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3496
Summary of Changes
change getKey to getPath to maybe make it clearer that it has more
tasks than setting the key
make objectInspector getPath method create a unique path, even if the
element is undefined
Test Plan
Unit tests