Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

readme clarification#3533

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
Anzumana:bugfix/readme_clarify
Aug 2, 2017
Merged

readme clarification#3533
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
Anzumana:bugfix/readme_clarify

Conversation

@Anzumana
Copy link
Copy Markdown
Contributor

@Anzumana Anzumana commented Aug 2, 2017

I joined the hangout instead of the Vidyo .
My hope is that with this change won't happen to anyone else.
Timezone conversions are a pain.

Associated Issue: #

Here's the Pull Request Doc
https://devtools-html.github.io/debugger.html/CONTRIBUTING.html#pull-requests

Summary of Changes

  • change 1
  • change 2

Test Plan

Tell us a little a bit about how you tested your patch.

Example test plan:

  • Command-P opens the panel
  • Clicking “+” opens the panel
  • Clicking a source navigates to the source
  • Clicking "x" closes the panel

Here's the Debugger's Testing doc
https://docs.google.com/document/d/1oBMRxV8A2ag2t22YsQOxTdEv0mXKzIg0tggJjRkU1S0/edit#.
Feel free to improve it!

Screenshots/Videos (OPTIONAL)

I joined the hangout instead of the Vidyo .
My hope is that with this change won't happen to anyone else.
Timezone conversions are a pain.
Copy link
Copy Markdown
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 2, 2017

Codecov Report

Merging #3533 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3533      +/-   ##
==========================================
+ Coverage   51.97%   51.99%   +0.02%     
==========================================
  Files         110      110              
  Lines        4529     4529              
  Branches      936      936              
==========================================
+ Hits         2354     2355       +1     
+ Misses       2175     2174       -1
Impacted Files Coverage Δ
src/actions/ast.js 78.57% <0%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbc889d...f1d5153. Read the comment docs.

@jasonLaster jasonLaster merged commit 57bf165 into firefox-devtools:master Aug 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants