This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Test symbol extraction for async/exported functions#3522
Merged
jasonLaster merged 1 commit intoAug 1, 2017
Merged
Conversation
4ba6eaa to
91deb2b
Compare
Codecov Report
@@ Coverage Diff @@
## master #3522 +/- ##
=========================================
- Coverage 51.97% 51.7% -0.28%
=========================================
Files 110 106 -4
Lines 4529 4377 -152
Branches 936 911 -25
=========================================
- Hits 2354 2263 -91
+ Misses 2175 2114 -61
Continue to review full report at Codecov.
|
Contributor
|
just noticed that jumpTo now has functions like exFoo!
|
Contributor
Author
|
Uh, that's neat. Seems like there's no support for async functions yet, though :-) |
Contributor
|
oh neat, it's good that we established the baseline. That'll be good to add in a separate PR :) We have tons of async functions in debugger.html |
Contributor
Author
|
Oh, I meant the GitHub "Jump to..." feature does not recognize async functions yet. The debugger.html does recognize them. |
Contributor
|
haha - that's hilarious. We're one step ahead of the pack.
We're also ahead of atom function search :)
…On Tue, Aug 1, 2017 at 4:11 PM Jan Kühle ***@***.***> wrote:
Oh, I meant the GitHub "Jump to..." feature does not recognize async
functions yet. The debugger.html does recognize them.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3522 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPiYrUlTxWOwWbPDgeIUHy9tGnrdFozks5sT4Z5gaJpZM4OqI-J>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3158
Summary of Changes