This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Convert App, SymbolModal and WelcomeBox components to JSX.#3507
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3507 +/- ##
==========================================
- Coverage 52.3% 51.49% -0.81%
==========================================
Files 112 110 -2
Lines 4562 4567 +5
Branches 940 944 +4
==========================================
- Hits 2386 2352 -34
- Misses 2176 2215 +39
Continue to review full report at Codecov.
|
jasonLaster
reviewed
Jul 31, 2017
Contributor
jasonLaster
left a comment
There was a problem hiding this comment.
This looks good to me. Lets get a couple more opinions on style though.
Also, I want to think about timing. It’s either this week or next week though.
Contributor
|
This looks awesome! |
ff31501 to
d3808e6
Compare
Contributor
|
I rebased and fixed up the flow types |
Contributor
|
looks like the pretty print test is failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3506
Getting the ball rolling on the JSX conversion
Summary of Changes
Test Plan
Example test plan: