Update webpack to version 3.3.0#3441
Conversation
eb9c137 to
961718f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3441 +/- ##
==========================================
+ Coverage 52.57% 52.59% +0.02%
==========================================
Files 119 119
Lines 4649 4649
Branches 958 958
==========================================
+ Hits 2444 2445 +1
+ Misses 2205 2204 -1
Continue to review full report at Codecov.
|
jasonLaster
left a comment
There was a problem hiding this comment.
Looks great, the one issue i see is that the pretty print worker cannot load the source map generator.
This keeps pretty print from working.
It shows up when you open the debugger in chrome
| @@ -0,0 +1,3 @@ | |||
| module.exports = { | |||
| plugins: [require("postcss-bidirection"), require("autoprefixer")] | |||
There was a problem hiding this comment.
I bet we can add postcss.config.js to the list of exported files and avoid this:
|
|
961718f to
022ae13
Compare
f855f06 to
cba3c1f
Compare
| post: | ||
| - yarn flow-coverage -- -t json -o $CIRCLE_TEST_REPORTS/flow-coverage | ||
| - yarn check | ||
| - yarn check --integrity |
There was a problem hiding this comment.
calling this out as it's a friendlier check.
we might want to go back to yarn check after we jump to react 15.6 or 16. At the moment we're so far back it's hurting us
Associated Issue: #2418 and others
This updates webpack to version 3.3.0.
Test Plan
npm packyarn add file:<path/to/packed/tgz>yarn startScreenshots/Videos (OPTIONAL)