Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Disable updating line number formats#3417

Merged
codehag merged 1 commit into
firefox-devtools:nextfrom
jasonLaster:fix-baby-bp
Jul 24, 2017
Merged

Disable updating line number formats#3417
codehag merged 1 commit into
firefox-devtools:nextfrom
jasonLaster:fix-baby-bp

Conversation

@jasonLaster

Copy link
Copy Markdown
Contributor

Associated Issue: #3383

Summary of Changes

  • Fixes a situation where toggling sources causes 1px BPs

[STR]

  1. navigate to https://devtools-html.github.io/debugger-examples/examples/todomvc/
  2. add a bp in todo-view.js and todo.js
  3. reload (view a bp in todo.js)
  4. click on the todo-view.js in the bp panel

AR: see the BP in todo-view
ER: see a 1px bp

@codecov

codecov Bot commented Jul 23, 2017

Copy link
Copy Markdown

Codecov Report

Merging #3417 into next will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           next   #3417   +/-   ##
====================================
  Coverage    50%     50%           
====================================
  Files       107     107           
  Lines      4460    4462    +2     
  Branches    920     921    +1     
====================================
+ Hits       2230    2231    +1     
- Misses     2230    2231    +1
Impacted Files Coverage Δ
src/utils/editor/source-documents.js 6% <0%> (-0.25%) ⬇️
src/actions/ast.js 78.57% <0%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4691d7a...c6fc6e2. Read the comment docs.

@codehag

codehag commented Jul 24, 2017

Copy link
Copy Markdown
Contributor

This looks good, it fixes the baby bps from WASM -- but we still have an issue with baby bps when switching panels. I will merge this and comment on the issue

@codehag codehag left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codehag codehag merged commit cd96df8 into firefox-devtools:next Jul 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants