This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Upgraded webpack to version 3.3.0#3360
Closed
zaggy wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Oh, I messed up with this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2418 (any other webpack update issue)
Summary of Changes
This just does bump flow-bin version and adds postcss.config.js file for webpack 3. It also updates webpack dependency but it looks like it has nothing to do with how project is built and real config is in devtools-launchpad.
So, this changes need to wait until PR#505 at devtools-core will land and new version of devtools-launchpad is released.
Test Plan
When new version of devtools-launchpad is released, visual testing is required. To run the project and check for errors. There is a very high chance of some regressions.
Screenshots/Videos (OPTIONAL)