This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Html syntax highlight bug#3271
Merged
jbhoosreddy merged 4 commits intoJul 6, 2017
Merged
Conversation
jbhoosreddy
commented
Jul 6, 2017
| return contentTypeModeMap["text/javascript"]; | ||
| } | ||
|
|
||
| if (isHTMLLike) { |
Contributor
Author
There was a problem hiding this comment.
I added a second check here because it can happen that we do have a contentType = "text/html" or it is equal to something else. In that case, we would still like to render it as htmlmixed.
I believe that this logic might be simplified if in devtools-core/devtools-source-maps we set html contentType to text/html for file extensions .html.
In fact, I'm not sure if there's any case for (!contentType && isHTMLLike) as far as I could tell in any codepath.
codehag
reviewed
Jul 6, 2017
|
|
||
| function getMode(source: Source) { | ||
| if (!source.text) { | ||
| const { contentType, text } = source; |
codehag
approved these changes
Jul 6, 2017
Contributor
Author
|
Since it's approved I'll go ahead and merge it. The failing CI test is only because of Percy. Rest of the tests pass and I double checked locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3222
Summary of Changes
Test Plan
Example test plan:
Screenshots/Videos (OPTIONAL)