Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Remove editor expression prop#3265

Merged
codehag merged 2 commits into
firefox-devtools:masterfrom
jasonLaster:kill-expressions
Jul 6, 2017
Merged

Remove editor expression prop#3265
codehag merged 2 commits into
firefox-devtools:masterfrom
jasonLaster:kill-expressions

Conversation

@jasonLaster
Copy link
Copy Markdown
Contributor

Found that this prop wasn't being used :)

Copy link
Copy Markdown
Contributor

@codehag codehag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 6, 2017

Codecov Report

Merging #3265 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3265      +/-   ##
==========================================
- Coverage   49.23%   49.17%   -0.07%     
==========================================
  Files          99       99              
  Lines        4135     4122      -13     
  Branches      853      850       -3     
==========================================
- Hits         2036     2027       -9     
+ Misses       2099     2095       -4
Impacted Files Coverage Δ
src/components/Editor/index.js 18.53% <ø> (-0.41%) ⬇️
src/utils/search/index.js 100% <0%> (ø) ⬆️
src/utils/search/count-matches.js
src/utils/search/project-search.js
src/components/PrimaryPanes/Outline.js
src/utils/search/build-query.js
src/utils/search/utils/build-query.js 96.55% <0%> (ø)
src/utils/search/worker.js 100% <0%> (ø)
src/utils/project-search.js 93.75% <0%> (ø)
src/components/Outline.js 76.66% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6935f26...0a65fbb. Read the comment docs.

@codehag codehag merged commit f1deb33 into firefox-devtools:master Jul 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants