Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Search worker#3249

Merged
wldcordeiro merged 2 commits into
firefox-devtools:masterfrom
wldcordeiro:search-worker
Jun 29, 2017
Merged

Search worker#3249
wldcordeiro merged 2 commits into
firefox-devtools:masterfrom
wldcordeiro:search-worker

Conversation

@wldcordeiro
Copy link
Copy Markdown
Contributor

Associated Issue: N/A

Summary of Changes

  • Move the project text search logic into the search worker and reorganize some of the files.

Test Plan

Tell us a little a bit about how you tested your patch.

Example test plan:

  • Ensure the projectTextSearch feature flag is enabled
  • Command-P opens the panel
  • Searching text across the project works

Signed-off-by: Wellington Cordeiro <wellington@wellingtoncordeiro.com>
Signed-off-by: Wellington Cordeiro <wellington@wellingtoncordeiro.com>
Copy link
Copy Markdown
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 29, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@d06552b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3249   +/-   ##
========================================
  Coverage          ?   49.2%           
========================================
  Files             ?      99           
  Lines             ?    4126           
  Branches          ?     850           
========================================
  Hits              ?    2030           
  Misses            ?    2096           
  Partials          ?       0
Impacted Files Coverage Δ
src/utils/editor/source-search.js 6.77% <ø> (ø)
src/utils/search/build-query.js 96.55% <ø> (ø)
src/utils/search/count-matches.js 100% <100%> (ø)
src/utils/search/project-search.js 94.44% <100%> (ø)
src/utils/search/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06552b...859ec55. Read the comment docs.

@wldcordeiro wldcordeiro merged commit 6715143 into firefox-devtools:master Jun 29, 2017
@wldcordeiro wldcordeiro deleted the search-worker branch June 29, 2017 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants