This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Added angular and rxjs to Library Frames#3241
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3241 +/- ##
==========================================
+ Coverage 49.18% 49.23% +0.04%
==========================================
Files 99 99
Lines 4125 4133 +8
Branches 850 852 +2
==========================================
+ Hits 2029 2035 +6
- Misses 2096 2098 +2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2980
Here's the Pull Request Doc
https://devtools-html.github.io/debugger.html/CONTRIBUTING.html#pull-requests
Summary of Changes
Test Plan
Sorry, no tests performed, as I again have some weird issues with running the project on Windows (and Linux too, for that instance). Had no time to fix those but thought it is still worth to push these changes. I hope somebody can test those (but think they can be landed anyway as they are very small changes and pretty straightforward).