[WIP] Symbols by jasonLaster · Pull Request #3229 · firefox-devtools/debugger

jasonLaster · 2017-06-26T21:52:07Z

Summary of Changes

I want to find all of the expressions in a file, this will let us anticipate what a user might want to preview or where a breakpoint might be added.

const obj = { a: { b: 2 } }; // e.g. obj.a.b
const foo = obj2.c.secondProperty; // e.g. foo.obj2.c.secondProperty

// computed properties
const com = { [a]: { b: "c" }, [b]: 3 }; // e.g. com[a].b

// assignments
obj.foo = { a: { b: "c" }, b: 3 }; // e.g. obj.foo.a.b
com = { a: { b: "c" }, b: 3 }; // e.g. com.a.b

// arrays
const res = [{ a: 2 }, { b: 3 }]; // e.g. res[1].b
const res2 = {a: [{b: 2}]}  // e.g. res.a[0].b
const res3 = [[{a:3}],[{b:3}]] // e.g. res[1][0].b

// destructuring
const { a, rest } = compute(stuff); // e.g. a
const [a, ...rest] = compute(stuff);

function params({ a, b }) {} // e.g. a
var pars = function({ a, b }) {};

const evil = obj2.doEvil().c.secondProperty; // e.g. obj2.doEvil or ""

Test Plan

Lots of tests, lots and lots of them

codecov · 2017-06-27T01:17:15Z

Codecov Report

Merging #3229 into master will increase coverage by 1.18%.
The diff coverage is 95.32%.

@@            Coverage Diff             @@
##           master    #3229      +/-   ##
==========================================
+ Coverage   47.71%   48.89%   +1.18%     
==========================================
  Files          98       98              
  Lines        4068     4174     +106     
  Branches      836      874      +38     
==========================================
+ Hits         1941     2041     +100     
- Misses       2127     2133       +6

Impacted Files	Coverage Δ
src/utils/parser/getSymbols.js	`96.15% <95.32%> (-3.85%)`	⬇️
src/utils/parser/utils/helpers.js	`94.11% <0%> (-2.95%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04703bc...3672fa2. Read the comment docs.

codehag

comments!

codehag · 2017-06-27T17:32:02Z

+
+        symbols.identifiers.push({
+          name: path.node.name,
+          expression: path.node.name,


we can

const { loc, name } = path.node;

at the top of this block

codehag · 2017-06-27T17:32:33Z

+      }
+
+      if (t.isVariableDeclarator(path)) {
+        const node = path.node.id;


this is a bit confusing, why is the node === path.node.id? could this be a mistake?

codehag · 2017-06-27T17:36:05Z

  return symbols;
 }
+
+function addProperty(name, expression, path, prevPath) {


rename to extendExpression

codehag · 2017-06-27T17:36:34Z

+function getObjectExpression(path, prevPath, expression = "") {
+  const name = path.node.key.name;
+
+  expression = addProperty(name, expression, path, prevPath);


rename to
const extendedExpression = extendExpression( ... )

codehag · 2017-06-27T17:37:40Z

+
+  expression = addProperty(name, expression, path, prevPath);
+
+  prevPath = path;


rename to
const nextPrevPath = path;

codehag · 2017-06-27T23:13:06Z

+  return getExpression(path, prevPath, expression);
+}
+
+function getExpression(path, prevPath, expression = "") {


this should probably be renamed to getExpressionName since it returns a string representation, and not the expression itself

snippit might be better

codehag · 2017-06-27T23:16:47Z

+    return name;
+  }
+
+  if (computed || array) {


i dont think we need this block, since it is doing the same thing as lines 160 - 164, and if it is computed -- we have an early return at line 150

codehag · 2017-06-27T23:18:27Z

+  expression = addProperty(index, expression, path, prevPath);
+
+  prevPath = path;
+  path = path.parentPath && path.parentPath.parentPath;


same for lines 202 204, 205 -- avoid renaming arguments

codehag · 2017-06-27T23:19:29Z

+  }
+
+  if (t.isVariableDeclarator(path)) {
+    const node = path.node.id;


again, a bit confused about why id is an node? would expect it to be a string...

codehag · 2017-06-27T23:19:50Z

+    }
+
+    const name = node.name;
+    const prop = addProperty(name, expression, path, prevPath);


we can directly return this

jasonLaster added 4 commits June 26, 2017 17:49

symbols

e4cb223

lj

8ea9641

more stuff

b06be75

lkj

1033ac8

jasonLaster added 4 commits June 27, 2017 01:15

lkj

477f01c

lj

3b9e8df

sdlkf

55ea44a

lkj

343436c

jasonLaster force-pushed the symbols branch from a43aa02 to 343436c Compare June 27, 2017 17:30

jasonLaster added 3 commits June 27, 2017 13:44

update tests

91c891a

lkjsdf

b778447

lkj

db3a40c

codehag reviewed Jun 27, 2017

View reviewed changes

codehag and others added 3 commits June 27, 2017 17:27

a bit of cleanup and renaming

8a88ee3

fix linter error

c4f1f0d

update tests

6d7b8c4

jasonLaster force-pushed the symbols branch from b9f920d to 6d7b8c4 Compare June 28, 2017 00:55

lkjsdf

3672fa2

jasonLaster merged commit 2e74914 into firefox-devtools:master Jun 28, 2017


		expression = addProperty(name, expression, path, prevPath);

		prevPath = path;

Conversation

jasonLaster commented Jun 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Test Plan

Uh oh!

codecov Bot commented Jun 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codehag left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jasonLaster commented Jun 26, 2017 •

edited

Loading

codecov Bot commented Jun 27, 2017 •

edited

Loading