Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Fix empty index.html breakpoints#3227

Merged
codehag merged 1 commit into
firefox-devtools:masterfrom
bomsy:bps-index
Jul 5, 2017
Merged

Fix empty index.html breakpoints#3227
codehag merged 1 commit into
firefox-devtools:masterfrom
bomsy:bps-index

Conversation

@bomsy
Copy link
Copy Markdown
Contributor

@bomsy bomsy commented Jun 25, 2017

Associated Issue: #3170

Summary of Changes

  • use the getFilename utility function instead of the basename, for consistency with Tabs and the Sourcetree

Test Plan

  • Go to the increment sourcemaps example.
  • Select the (index) in the sourcetree
  • Add breakpoint in the file
  • Should see (index) in the breakpoints list

Screenshots/Videos (OPTIONAL)

Before

After

image

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 25, 2017

Codecov Report

Merging #3227 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3227      +/-   ##
=========================================
+ Coverage   47.71%   47.9%   +0.19%     
=========================================
  Files          98      98              
  Lines        4068    4064       -4     
  Branches      836     835       -1     
=========================================
+ Hits         1941    1947       +6     
+ Misses       2127    2117      -10
Impacted Files Coverage Δ
src/actions/navigation.js 15.38% <0%> (+2.05%) ⬆️
src/reducers/sources.js 79.02% <0%> (+3.15%) ⬆️
src/reducers/async-requests.js 100% <0%> (+8.33%) ⬆️
src/reducers/event-listeners.js 33.33% <0%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b543bc8...78ba557. Read the comment docs.

@codehag
Copy link
Copy Markdown
Contributor

codehag commented Jul 5, 2017

Looks great!

@codehag codehag merged commit def2de3 into firefox-devtools:master Jul 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants