This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Stop scrolling when we toggle tools#3225
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3225 +/- ##
======================================
Coverage 47.9% 47.9%
======================================
Files 98 98
Lines 4064 4064
Branches 835 835
======================================
Hits 1947 1947
Misses 2117 2117Continue to review full report at Codecov.
|
jasonLaster
commented
Jun 24, 2017
| pressKey(dbg, "inspector"); | ||
| pressKey(dbg, "debugger"); | ||
|
|
||
| is(dbg.win.cm.getScrollInfo().top, 284); |
Contributor
Author
There was a problem hiding this comment.
we can always test more invariants like bps, search state... but I prefer a minimal test that correlates with the behavior. We should to more tests on the unit side
bomsy
reviewed
Jun 24, 2017
| * because it is more reliable than either checking a focus state or | ||
| * the visibleState or hidden property. | ||
| */ | ||
| export function isVisible() { |
Contributor
There was a problem hiding this comment.
does isVisible feels vague, maybe something like isAppVisible is a bit clearer?
Contributor
Author
There was a problem hiding this comment.
yeah - that's fair
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3168 #3033
Summary of Changes
Test Plan