get bracketarrow working again#3224
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3224 +/- ##
=======================================
Coverage 47.71% 47.71%
=======================================
Files 98 98
Lines 4068 4068
Branches 836 836
=======================================
Hits 1941 1941
Misses 2127 2127
Continue to review full report at Codecov.
|
jasonLaster
left a comment
There was a problem hiding this comment.
This is great. Thanks
| "" | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
oh interesting, why does this need to be a component over a function?
| left: PropTypes.number, | ||
| top: PropTypes.number, | ||
| bottom: PropTypes.number | ||
| }; |
There was a problem hiding this comment.
We're now using props, which is flow based.
Checkout https://github.com/devtools-html/debugger.html/blob/master/src/components/Editor/Footer.js#L25-L35
ec600f7 to
95d4554
Compare
|
@jasonLaster you were right, no reason to use a class when a function suffices. I tested in firefox 54.0 and changed the position of the arrow which was a bit off. |
|
Great. Thanks for the fix |
| top: number, | ||
| bottom: number | ||
| ) => { | ||
| }) => { |
Associated Issue: #3109
Summary of Changes
Test Plan
Start debugging a file and mouse over a variable while stepping through code. The poup
has a small arrow pointing to the variable.