This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix reloading issue with selected tabs + breakpoints#3220
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3220 +/- ##
=========================================
- Coverage 47.9% 47.71% -0.2%
=========================================
Files 98 98
Lines 4064 4068 +4
Branches 835 836 +1
=========================================
- Hits 1947 1941 -6
- Misses 2117 2127 +10
Continue to review full report at Codecov.
|
jasonLaster
commented
Jun 24, 2017
|
|
||
| if (!url) { | ||
| return initialState(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
this is a race condition where we don't have a selected source, but we had one prior... It's a small fix that came from some fast tests.
* affects selected tabs * casues breakpoints to shift on reload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3221
We were seeing two issues:
how is everything fixed? I changed the action from navigate to connect which now just sets the debuggee url and does not clear any state. I also added lots of tests!