This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Include comments in "out of scope" locations#3200
Merged
Merged
Conversation
wldcordeiro
reviewed
Jun 22, 2017
| * source | ||
| */ | ||
| function findFunctions(source: SourceText) { | ||
| function findSymbols(source: SourceText) { |
Contributor
There was a problem hiding this comment.
This findSymbols/findFunctions function seems odd to me. Couldn't we reuse this getSymbols function and modify it to extract comments?
Codecov Report
@@ Coverage Diff @@
## master #3200 +/- ##
==========================================
+ Coverage 49.22% 49.44% +0.22%
==========================================
Files 99 99
Lines 4132 4150 +18
Branches 853 854 +1
==========================================
+ Hits 2034 2052 +18
Misses 2098 2098
Continue to review full report at Codecov.
|
Contributor
|
updated and rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3055
Summary of Changes
Test Plan
the only reason this PR is under my account is that @giladartzi's machine didn't compile the code properly. Beautiful work in #goodnessSquad