Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Change default case sensitive search modifier to off#3199

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
ohana54:fix_3068
Jun 21, 2017
Merged

Change default case sensitive search modifier to off#3199
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
ohana54:fix_3068

Conversation

@ohana54
Copy link
Copy Markdown
Contributor

@ohana54 ohana54 commented Jun 21, 2017

Associated Issue: #3068

Summary of Changes

  • Change the default case sensitive search modifier to be turned off, meaning the search is case-insensitive by default.

#goodnessSquad

Copy link
Copy Markdown
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Assuming that it works when you test it out :)

@ohana54
Copy link
Copy Markdown
Contributor Author

ohana54 commented Jun 21, 2017

Was just about to write - it works in dev, how do I test the "production" preferences?
I tried disabling the development overrides, but the debugger failed to load as a result.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 21, 2017

Codecov Report

Merging #3199 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3199      +/-   ##
==========================================
+ Coverage   47.82%   47.83%   +0.01%     
==========================================
  Files          98       98              
  Lines        4065     4064       -1     
  Branches      839      838       -1     
==========================================
  Hits         1944     1944              
+ Misses       2121     2120       -1
Impacted Files Coverage Δ
src/utils/prefs.js 100% <100%> (ø) ⬆️
src/components/Editor/index.js 19.31% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29ad53...888119e. Read the comment docs.

@jasonLaster
Copy link
Copy Markdown
Contributor

it's hard to test in firefox, but that's why we have development.

Thanks!

@jasonLaster jasonLaster merged commit 4448bbd into firefox-devtools:master Jun 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants