Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Style command bar animations#3194

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:style-cmds
Jun 21, 2017
Merged

Style command bar animations#3194
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:style-cmds

Conversation

@jasonLaster
Copy link
Copy Markdown
Contributor

@jasonLaster jasonLaster commented Jun 21, 2017

Summary of Changes

Our step animations were taking much longer than the time it took to step, which was crazy. This fixes that!

Before

After

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 21, 2017

Codecov Report

Merging #3194 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3194      +/-   ##
==========================================
- Coverage   47.82%   47.63%   -0.19%     
==========================================
  Files          98       98              
  Lines        4065     4062       -3     
  Branches      839      837       -2     
==========================================
- Hits         1944     1935       -9     
- Misses       2121     2127       +6
Impacted Files Coverage Δ
src/utils/sources-tree.js 87.5% <0%> (-4.97%) ⬇️
src/components/Editor/index.js 19.31% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29ad53...c0e1946. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 21, 2017 •
edited
Loading

Codecov Report

Merging #3194 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3194      +/-   ##
==========================================
- Coverage   47.82%   47.63%   -0.19%     
==========================================
  Files          98       98              
  Lines        4065     4062       -3     
  Branches      839      837       -2     
==========================================
- Hits         1944     1935       -9     
- Misses       2121     2127       +6
Impacted Files Coverage Δ
src/utils/sources-tree.js 87.5% <0%> (-4.97%) ⬇️
src/components/Editor/index.js 19.31% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29ad53...c0e1946. Read the comment docs.

wldcordeiro
wldcordeiro approved these changes Jun 21, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@wldcordeiro wldcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Simple solution. I think we could have maybe kept the animation and removed the use of setTimeout in favor of RAF or https://github.com/reactjs/react-transition-group but this is a good solution.

@jasonLaster jasonLaster merged commit 5669e63 into firefox-devtools:master Jun 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@wldcordeiro wldcordeiro wldcordeiro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jasonLaster @wldcordeiro