This repository was archived by the owner on Jan 11, 2023. It is now read-only.
(WIP) Replace sourcetext w/ source#3190
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3190 +/- ##
==========================================
- Coverage 47.82% 47.62% -0.21%
==========================================
Files 98 98
Lines 4065 4059 -6
Branches 839 837 -2
==========================================
- Hits 1944 1933 -11
- Misses 2121 2126 +5
Continue to review full report at Codecov.
|
codehag
approved these changes
Jun 20, 2017
Contributor
codehag
left a comment
There was a problem hiding this comment.
LGTM! is there much more to do on this one?
codehag
approved these changes
Jun 21, 2017
Contributor
codehag
left a comment
There was a problem hiding this comment.
Looks great, two questions only
| */ | ||
| declare type Source = { | ||
| id: SourceId, | ||
| url?: string, |
Contributor
There was a problem hiding this comment.
is it possible that a source will not have a url? for example, a javascript:<name> script tag?
| declare type Source = { | ||
| id: SourceId, | ||
| url?: string, | ||
| sourceMapURL?: string, |
Contributor
There was a problem hiding this comment.
will an original source have a sourceMapUrl?
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3078
Summary of Changes