Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Start project search#3177

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:sps
Jun 18, 2017
Merged

Start project search#3177
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:sps

Conversation

@jasonLaster

Copy link
Copy Markdown
Contributor

Associated Issue: #1108

Summary of Changes

  • connects the dots between ProjectSearch, TextSearch, and searchSource
  • wires up SearchInput and knows how to show the count

Lots to do, but this is a start

Screenshots/Videos (OPTIONAL)

@codecov

codecov Bot commented Jun 15, 2017

Copy link
Copy Markdown

Codecov Report

Merging #3177 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3177   +/-   ##
=======================================
  Coverage   47.59%   47.59%           
=======================================
  Files          97       97           
  Lines        4036     4036           
  Branches      828      828           
=======================================
  Hits         1921     1921           
  Misses       2115     2115
Impacted Files Coverage Δ
src/utils/project-search.js 93.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38e1558...1a0ff1c. Read the comment docs.

@jasonLaster jasonLaster force-pushed the sps branch 2 times, most recently from cbbd320 to 935bc69 Compare June 18, 2017 05:12
@jasonLaster jasonLaster merged commit a8e5677 into firefox-devtools:master Jun 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant