Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

[Documentation] running the debugger as part of a firefox build#3174

Merged
codehag merged 3 commits into
firefox-devtools:masterfrom
codehag:feature/3169-documentation-running-the-debugger-as-part-of-a-firefox-build
Jun 19, 2017
Merged

[Documentation] running the debugger as part of a firefox build#3174
codehag merged 3 commits into
firefox-devtools:masterfrom
codehag:feature/3169-documentation-running-the-debugger-as-part-of-a-firefox-build

Conversation

@codehag
Copy link
Copy Markdown
Contributor

@codehag codehag commented Jun 14, 2017

Associated Issue: #3169

Add documentation about how to run as a panel

@codehag codehag changed the title Feature/3169 documentation running the debugger as part of a firefox build [Documentation] running the debugger as part of a firefox build Jun 14, 2017
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 14, 2017

Codecov Report

Merging #3174 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3174   +/-   ##
=======================================
  Coverage   47.59%   47.59%           
=======================================
  Files          97       97           
  Lines        4036     4036           
  Branches      828      828           
=======================================
  Hits         1921     1921           
  Misses       2115     2115

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d0925...cc2d31b. Read the comment docs.

@wldcordeiro
Copy link
Copy Markdown
Contributor

Reading through this now! @codehag thanks so much for doing this, it's been something we've been needing. 😄

Comment thread docs/running-as-firefox-panel.md Outdated

## Getting Started with Firefox Nightly

Running firefox is similar to running [Mochitests](./mochitests.md)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: capitalize Firefox.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps:

similar to running Mochitests (our integration tests)

Copy link
Copy Markdown
Contributor

@wldcordeiro wldcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! The writing is great, simple and informative.

Copy link
Copy Markdown
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Comment thread docs/running-as-firefox-panel.md Outdated

## Getting Started with Firefox Nightly

Running firefox is similar to running [Mochitests](./mochitests.md)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps:

similar to running Mochitests (our integration tests)

Comment thread docs/running-as-firefox-panel.md Outdated
There are two commands that you will need. `./mach build` and `./mach run` these can be run together
each time things change with `./mach build && ./mach run`

* The first time you run the project you will need to use `./mach build` but after the first run you can use `./mach build faster`! The full command looks like this`./mach build faster && ./mach run`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets link to docs: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/mach
I'd rather people learn about edge cases there!

On the first run, this will download a local copy of Firefox and set up an [artifact build](https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds) (just think of a super fast Firefox build). It may take a while (10-15 minutes) to download and build Firefox.

There are two commands that you will need. `./mach build` and `./mach run` these can be run together
each time things change with `./mach build && ./mach run`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we mention clobber?

in npm:
```
npm run copy-assets
```
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets leave out the npm flavor. I think we should expect people to be able to convert btw the two

Comment thread docs/running-as-firefox-panel.md Outdated
It's annoying to have to manually update the bundle every single time though. If you want to automatically update the bundle in Firefox whenever you make a change, run this:

```
npm run copy-assets-watch
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn

Comment thread docs/running-as-firefox-panel.md Outdated
Now we can put these pieces together. After you copy over the assets, you can run firefox with the
debugger inside the panel!

in debugger project (`projects/debugger.html` or whereever you have it!):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wherever

Comment thread docs/running-as-firefox-panel.md Outdated

in debugger project (`projects/debugger.html` or whereever you have it!):
```
npm run copy-assets-watch
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn

Comment thread docs/running-as-firefox-panel.md Outdated

You can change this to what works for you!

## Watching for Changes
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to move## Running Nightly with the local debugger up higher.

I could see moving some of this extra info to an Appendix, which gives people extra info without distracting them from the primary task, which is seeing their version of the debugger in FF!

@codehag codehag merged commit 304e33e into firefox-devtools:master Jun 19, 2017
@codehag codehag deleted the feature/3169-documentation-running-the-debugger-as-part-of-a-firefox-build branch June 19, 2017 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants