Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Bug/3049 debugger is blank when clicking on stacktrace in netmonitor first#3166

Merged
codehag merged 4 commits into
firefox-devtools:masterfrom
codehag:bug/3049-debugger-is-blank-when-clicking-on-stacktrace-in-netmonitor-first
Jun 14, 2017
Merged

Bug/3049 debugger is blank when clicking on stacktrace in netmonitor first#3166
codehag merged 4 commits into
firefox-devtools:masterfrom
codehag:bug/3049-debugger-is-blank-when-clicking-on-stacktrace-in-netmonitor-first

Conversation

@codehag

@codehag codehag commented Jun 13, 2017

Copy link
Copy Markdown
Contributor

Associated Issue: #3049 #3159

testing:

@jasonLaster jasonLaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier is weird, but otherwise everything looks good

@codecov

codecov Bot commented Jun 14, 2017

Copy link
Copy Markdown

Codecov Report

Merging #3166 into master will increase coverage by 0.04%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3166      +/-   ##
==========================================
+ Coverage   47.43%   47.48%   +0.04%     
==========================================
  Files          97       97              
  Lines        4018     4018              
  Branches      826      826              
==========================================
+ Hits         1906     1908       +2     
+ Misses       2112     2110       -2
Impacted Files Coverage Δ
src/utils/frame.js 84.48% <ø> (ø) ⬆️
src/components/Editor/index.js 20.16% <0%> (ø) ⬆️
src/utils/prefs.js 100% <100%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11757c9...a084c1a. Read the comment docs.

@codecov

codecov Bot commented Jun 14, 2017

Copy link
Copy Markdown

Codecov Report

Merging #3166 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3166      +/-   ##
==========================================
+ Coverage   47.43%   47.48%   +0.04%     
==========================================
  Files          97       97              
  Lines        4018     4018              
  Branches      826      826              
==========================================
+ Hits         1906     1908       +2     
+ Misses       2112     2110       -2
Impacted Files Coverage Δ
src/utils/prefs.js 100% <100%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11757c9...a084c1a. Read the comment docs.

@codehag codehag merged commit 9c0aa78 into firefox-devtools:master Jun 14, 2017
@codehag codehag deleted the bug/3049-debugger-is-blank-when-clicking-on-stacktrace-in-netmonitor-first branch June 14, 2017 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants