Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Add void types#3157

Merged
codehag merged 2 commits into
firefox-devtools:masterfrom
jasonLaster:add-voids
Jun 12, 2017
Merged

Add void types#3157
codehag merged 2 commits into
firefox-devtools:masterfrom
jasonLaster:add-voids

Conversation

@jasonLaster

@jasonLaster jasonLaster commented Jun 12, 2017

Copy link
Copy Markdown
Contributor

Associated Issue: #3156

Summary of Changes

Replace some return anys with voids. this gets us one % bump :)

@codecov

codecov Bot commented Jun 12, 2017

Copy link
Copy Markdown

Codecov Report

Merging #3157 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3157   +/-   ##
======================================
  Coverage    47.4%   47.4%           
======================================
  Files          97      97           
  Lines        4014    4014           
  Branches      825     825           
======================================
  Hits         1903    1903           
  Misses       2111    2111
Impacted Files Coverage Δ
src/components/Editor/Footer.js 3.84% <ø> (ø) ⬆️
src/components/shared/ManagedTree.js 5.35% <ø> (ø) ⬆️
src/components/shared/SearchInput.js 8.69% <ø> (ø) ⬆️
src/components/shared/ObjectInspector.js 7.4% <ø> (ø) ⬆️
src/components/Editor/Preview.js 5.17% <ø> (ø) ⬆️
src/components/Editor/SearchBar.js 22.04% <ø> (ø) ⬆️
src/components/shared/Button/PaneToggle.js 7.69% <ø> (ø) ⬆️
src/components/shared/ResultList.js 100% <ø> (ø) ⬆️
src/components/Outline.js 76.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea8dccf...d5718c5. Read the comment docs.

@codehag codehag left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codehag codehag merged commit 8c2ed12 into firefox-devtools:master Jun 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants