Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Bump flow bin version#3155

Merged
jasonLaster merged 5 commits into
firefox-devtools:masterfrom
zaggy:bump-flow-bin-version
Jun 12, 2017
Merged

Bump flow bin version#3155
jasonLaster merged 5 commits into
firefox-devtools:masterfrom
zaggy:bump-flow-bin-version

Conversation

@zaggy

@zaggy zaggy commented Jun 12, 2017

Copy link
Copy Markdown
Contributor

Associated Issue: #3141 #3012

Here's the Pull Request Doc
https://devtools-html.github.io/debugger.html/CONTRIBUTING.html#pull-requests

Summary of Changes

  • Updated flow-bin to the version 0.47
  • Fixed all errors throughout the code.

While I patched the code to throw no errors, it contains so many anys that it becomes useless to use flow at all. I think that another activity is required to go through all any references and figure out exact types there should be.

Test Plan

No test are requires. Unit tests on CI should fail, but this is due to the flow issues in devtools-launchpad.

Screenshots/Videos (OPTIONAL)

@codecov

codecov Bot commented Jun 12, 2017

Copy link
Copy Markdown

Codecov Report

Merging #3155 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3155   +/-   ##
=======================================
  Coverage   47.42%   47.42%           
=======================================
  Files          97       97           
  Lines        4013     4013           
  Branches      825      825           
=======================================
  Hits         1903     1903           
  Misses       2110     2110
Impacted Files Coverage Δ
src/components/Editor/Preview.js 5.17% <ø> (ø) ⬆️
src/components/shared/ManagedTree.js 5.35% <ø> (ø) ⬆️
src/components/shared/ResultList.js 100% <ø> (ø) ⬆️
src/reducers/ast.js 88.57% <ø> (ø) ⬆️
src/components/Editor/index.js 20.16% <0%> (ø) ⬆️
src/actions/sources.js 50.62% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd8592c...8425723. Read the comment docs.

@codecov

codecov Bot commented Jun 12, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3155 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3155   +/-   ##
======================================
  Coverage    47.4%   47.4%           
======================================
  Files          97      97           
  Lines        4014    4014           
  Branches      825     825           
======================================
  Hits         1903    1903           
  Misses       2111    2111
Impacted Files Coverage Δ
src/components/shared/ResultList.js 100% <ø> (ø) ⬆️
src/reducers/ast.js 88.57% <ø> (ø) ⬆️
src/components/Editor/Preview.js 5.17% <ø> (ø) ⬆️
src/components/shared/ManagedTree.js 5.35% <ø> (ø) ⬆️
src/actions/sources.js 50.62% <0%> (ø) ⬆️
src/components/Editor/index.js 20.16% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72aa1a...ca2914a. Read the comment docs.

@codehag

codehag commented Jun 12, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

For now lets wait until the other change gets merged in :) otherwise other prs branching from this one will be confused why the flow checker is complaining

codehag
codehag approved these changes Jun 12, 2017
View reviewed changes
Comment thread src/components/Editor/Preview.js
return dom.div(
{},
this.renderObjectPreview(expression, root),
this.renderAddToExpressionBar(expression, value)

@codehag codehag Jun 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread src/components/Editor/index.js
}

if (this.isCbPanelOpen()) {
return this.closeConditionalPanel(line);

@codehag codehag Jun 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zaggy

zaggy commented Jun 12, 2017

Copy link
Copy Markdown
Contributor Author

I have already made a PR in firefox-devtools/devtools-core#439 .

@jasonLaster jasonLaster force-pushed the bump-flow-bin-version branch from 8425723 to ca2914a Compare June 12, 2017 14:05
@jasonLaster jasonLaster merged commit ea8dccf into firefox-devtools:master Jun 12, 2017
@zaggy zaggy deleted the bump-flow-bin-version branch July 25, 2017 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@codehag codehag codehag approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zaggy @codehag @jasonLaster