This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Search bar doesn't get focus if already open#3153
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3153 +/- ##
=========================================
- Coverage 47.42% 47.4% -0.02%
=========================================
Files 97 97
Lines 4013 4014 +1
Branches 825 825
=========================================
Hits 1903 1903
- Misses 2110 2111 +1
Continue to review full report at Codecov.
|
Contributor
|
Hi! Thanks for the bug report and the PR. I tried to replicate the bug behavior you described, but I wasn't able to. Can you give me a scenario to follow to confirm the fix? Just the series of steps that you took to discover the bug. These are the steps I followed:
On both master and this branch this works, so I am probably missing something. Thanks! |
Contributor
|
Thanks @amitzur! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3152
Summary of Changes
toggleSearchwas called, which in turn callsselectSearchInputwhich selects the entire range in the input. But it doesn't focus.I just added focus() inside
selectSearchInput.