This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix 3146 - editor occassionaly doesn't jump to a line#3147
Merged
Conversation
1a6fead to
8ced320
Compare
jasonLaster
commented
Jun 9, 2017
| } else if (selectedSource.get("error")) { | ||
| this.showMessage(selectedSource.get("error")); | ||
| } else if (this.props.selectedSource !== selectedSource) { | ||
| this.showSourceText(selectedSource, selectedLocation); |
Contributor
Author
There was a problem hiding this comment.
decided to drop some sourceText refs while i was here
| function isTextForSource(sourceText) { | ||
| return !sourceText.get("loading") && !sourceText.get("error"); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
this method was not helpful :)
| return { id: source.id, loading: true }; | ||
| } else if (action.status === "error") { | ||
| return { error: action.error, loading: false }; | ||
| return { id: source.id, error: action.error, loading: false }; |
Contributor
Author
There was a problem hiding this comment.
this fixes a bug where source wasn't getting these field because it couldn't merge w/o an id
8ced320 to
25b61a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #3147 +/- ##
========================================
- Coverage 47.49% 47.3% -0.2%
========================================
Files 97 95 -2
Lines 4009 4004 -5
Branches 825 825
========================================
- Hits 1904 1894 -10
- Misses 2105 2110 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3147 +/- ##
==========================================
- Coverage 47.49% 47.42% -0.08%
==========================================
Files 97 97
Lines 4009 4013 +4
Branches 825 825
==========================================
- Hits 1904 1903 -1
- Misses 2105 2110 +5
Continue to review full report at Codecov.
|
25b61a8 to
5dd237c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3146
Summary of Changes
This fixes an annoying issue where the debugger would occasionally forget to jump to a line. the issue was that when you wanted to go to a source that was hidden, the first attempt would be to go to the line, then a second attempt would be to move the tab. The second attempt cleared the line number. The fix is to introduce a new action