Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Update outdated deps#3142

Merged
jasonLaster merged 3 commits into
firefox-devtools:masterfrom
clarkbw:update-outdated-deps
Jun 9, 2017
Merged

Update outdated deps#3142
jasonLaster merged 3 commits into
firefox-devtools:masterfrom
clarkbw:update-outdated-deps

Conversation

@clarkbw

@clarkbw clarkbw commented Jun 8, 2017

Copy link
Copy Markdown
Contributor

Associated Issue: #3141

Summary of Changes

  • remove firefox-profile which was pulled in for integration tests 59821b2 but that work has moved to the launchpad and this module doesn't work well with selenium now anyway.
  • WIP

@codecov

codecov Bot commented Jun 8, 2017

Copy link
Copy Markdown

Codecov Report

Merging #3142 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3142   +/-   ##
=======================================
  Coverage   47.37%   47.37%           
=======================================
  Files          95       95           
  Lines        4000     4000           
  Branches      825      825           
=======================================
  Hits         1895     1895           
  Misses       2105     2105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bccea79...1600ca0. Read the comment docs.

@clarkbw clarkbw mentioned this pull request Jun 8, 2017
10 tasks
@clarkbw

clarkbw commented Jun 9, 2017

Copy link
Copy Markdown
Contributor Author

The default size changes for percy are what broke the build. All the screenshots are at least 800 px in height now.

@jasonLaster

Copy link
Copy Markdown
Contributor

Yep - im not too worried. they're changing some defaults around

@jasonLaster jasonLaster merged commit c6a5d8b into firefox-devtools:master Jun 9, 2017
@clarkbw clarkbw deleted the update-outdated-deps branch June 9, 2017 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants