This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Create search worker#3139
Merged
Merged
Conversation
jasonLaster
commented
Jun 8, 2017
| self.postMessage({ id, error: e }); | ||
| } | ||
| }; | ||
| self.onmessage = workerHandler({ prettyPrint }); |
Contributor
Author
There was a problem hiding this comment.
did a bit of clean up while i was in the worker code
2b86fcc to
7e23243
Compare
Codecov Report
@@ Coverage Diff @@
## master #3139 +/- ##
==========================================
- Coverage 47.37% 45.84% -1.53%
==========================================
Files 95 97 +2
Lines 4000 4009 +9
Branches 825 825
==========================================
- Hits 1895 1838 -57
- Misses 2105 2171 +66
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3139 +/- ##
==========================================
+ Coverage 47.37% 47.49% +0.11%
==========================================
Files 95 97 +2
Lines 4000 4009 +9
Branches 825 825
==========================================
+ Hits 1895 1904 +9
Misses 2105 2105
Continue to review full report at Codecov.
|
60d74da to
ac1e80e
Compare
ac1e80e to
97e8356
Compare
jasonLaster
commented
Jun 9, 2017
| export const getClosestExpression = dispatcher.task("getClosestExpression"); | ||
| export const getSymbols = dispatcher.task("getSymbols"); | ||
| export const getVariablesInScope = dispatcher.task("getVariablesInScope"); | ||
| export const getOutOfScopeLocations = dispatcher.task("getOutOfScopeLocations"); |
Contributor
Author
There was a problem hiding this comment.
ooh, we an use export directly and avoid the module.exports... yay
nchevobbe
approved these changes
Jun 9, 2017
nchevobbe
left a comment
Member
There was a problem hiding this comment.
2 minor things, but looks good overall
| return match ? match.length : 0; | ||
| } | ||
|
|
||
| debugger; |
| text: string, | ||
| modifiers: SearchModifiers | ||
| ): number { | ||
| debugger; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3096
Summary of Changes
countMatchesfunction to a worker, which will keep the main thread from janking up when we search big files