This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Add WTR Runner#3138
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3138 +/- ##
=======================================
Coverage 47.59% 47.59%
=======================================
Files 97 97
Lines 4036 4036
Branches 828 828
=======================================
Hits 1921 1921
Misses 2115 2115Continue to review full report at Codecov.
|
codehag
reviewed
Jun 12, 2017
codehag
left a comment
Contributor
There was a problem hiding this comment.
Looks good save for one console log that was confusing.
| Runtime.enable(); | ||
| Runtime.consoleAPICalled(({ type, args }) => { | ||
| const argVals = args.map(arg => arg.value).join(", "); | ||
| console.log(argVals); |
Contributor
There was a problem hiding this comment.
do we need this console log? If so should it have a descriptive text?
Contributor
Author
There was a problem hiding this comment.
I think it's nice to have it for now. It's easy to take out and tweak later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2634
Summary of Changes
This re-introduces the work done here: #2852 to have a wtr headless runner. The test runs fail, but it's still good to have in the codebase so that we can get the tests passing and then run it in CI.
NOTE: you need to start chrome headlessly to run the tests
canary --headless --remote-debugging-port=9222 https://chromium.org