Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

style exceptions in WhyPaused as red#3136

Merged
jasonLaster merged 2 commits into
firefox-devtools:masterfrom
zaggy:update-why-paused
Jun 8, 2017
Merged

style exceptions in WhyPaused as red#3136
jasonLaster merged 2 commits into
firefox-devtools:masterfrom
zaggy:update-why-paused

Conversation

@zaggy

@zaggy zaggy commented Jun 8, 2017

Copy link
Copy Markdown
Contributor

Associated Issue: #3130

Summary of Changes

  • Changed the color of error message to var(--theme-graphs-full-red) and made it bold

Test Plan

  • open the debugger
  • turn on "Pause on uncaught exceptions"
  • open this example page
  • when debugger pauses on exception you should see the error details in red

Here's the Debugger's Testing doc
https://docs.google.com/document/d/1oBMRxV8A2ag2t22YsQOxTdEv0mXKzIg0tggJjRkU1S0/edit#.
Feel free to improve it!

Screenshots/Videos (OPTIONAL)

image

@jasonLaster jasonLaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov

codecov Bot commented Jun 8, 2017

Copy link
Copy Markdown

Codecov Report

Merging #3136 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3136   +/-   ##
=======================================
  Coverage   47.37%   47.37%           
=======================================
  Files          95       95           
  Lines        4000     4000           
  Branches      825      825           
=======================================
  Hits         1895     1895           
  Misses       2105     2105
Impacted Files Coverage Δ
src/components/SecondaryPanes/Frames/WhyPaused.js 90.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2af129...450d701. Read the comment docs.

@codecov

codecov Bot commented Jun 8, 2017

Copy link
Copy Markdown

Codecov Report

Merging #3136 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3136   +/-   ##
=======================================
  Coverage   47.37%   47.37%           
=======================================
  Files          95       95           
  Lines        4000     4000           
  Branches      825      825           
=======================================
  Hits         1895     1895           
  Misses       2105     2105
Impacted Files Coverage Δ
src/components/SecondaryPanes/Frames/WhyPaused.js 90.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2af129...450d701. Read the comment docs.

@jasonLaster jasonLaster merged commit 3908764 into firefox-devtools:master Jun 8, 2017
@zaggy zaggy deleted the update-why-paused branch July 25, 2017 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants